Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Let's try GraphQL Schema Autoconfiguration with stitching several schemas together #70

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented Jan 26, 2019

Fixes #64

@igdianov igdianov self-assigned this Jan 26, 2019
@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #70 into master will increase coverage by 3.89%.
The diff coverage is 90.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     61.73%   65.63%   +3.89%     
- Complexity      260      326      +66     
============================================
  Files            21       24       +3     
  Lines          1657     1903     +246     
  Branches        269      326      +57     
============================================
+ Hits           1023     1249     +226     
- Misses          516      524       +8     
- Partials        118      130      +12
Impacted Files Coverage Δ Complexity Δ
...utoconfigure/GraphQLJpaQueryAutoConfiguration.java 100% <100%> (ø) 1 <0> (ø) ⬇️
.../query/autoconfigure/GraphQLShemaRegistration.java 100% <100%> (ø) 3 <3> (?)
.../query/autoconfigure/GraphQLSchemaFactoryBean.java 87.09% <87.09%> (ø) 7 <7> (?)
.../autoconfigure/GraphQLSchemaAutoConfiguration.java 90% <90%> (ø) 4 <4> (?)
...graphql/jpa/query/schema/impl/PredicateFilter.java 94.11% <0%> (-2.18%) 7% <0%> (+3%)
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 88.9% <0%> (+1.12%) 102% <0%> (+40%) ⬆️
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 52.84% <0%> (+8.18%) 49% <0%> (+9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007014b...f7b3582. Read the comment docs.

@igdianov igdianov changed the title feat: initial GraphQL Schema Autoconfiguration with merge feat: Let's try GraphQL Schema Autoconfiguration with stitching several schemas together Jan 26, 2019
@igdianov igdianov merged commit 332bb02 into master Jan 31, 2019
@igdianov igdianov deleted the igdianov-schema-merge branch January 31, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant