fix tests on 1.8 #13
Merged
fix tests on 1.8 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the CI workflow got disabled |
oxinabox
reviewed
Aug 19, 2022
test/robust_pmap.jl
Outdated
Comment on lines
20
to
24
| if VERSION < v"1.8-" | ||
| @test_throws ErrorException robust_pmap(throw_isodd, input) | ||
| else | ||
| @test_throws "Error" robust_pmap(throw_isodd, input) | ||
| end |
There was a problem hiding this comment.
if we are testing for presents of the word Error then we might as well just
Suggested change
| if VERSION < v"1.8-" | |
| @test_throws ErrorException robust_pmap(throw_isodd, input) | |
| else | |
| @test_throws "Error" robust_pmap(throw_isodd, input) | |
| end | |
| @test_throws Exception robust_pmap(throw_isodd, input) |
There was a problem hiding this comment.
Well, just since the string message is Error here... could change it to ErrorException("Error123") and test for "Error123"
oxinabox
approved these changes
Aug 19, 2022
oxinabox
approved these changes
Aug 23, 2022
|
Thanks |
|
Thanks for maintaining parallelism! I use a modified version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.8,
asyncmapthrows CapturedExceptions so the stacktrace doesn't get dropped (JuliaLang/julia#42105). This doesn't break pmap retries (because they get unwrapped) but it does change the exception getting thrown, so it breaks the tests here.This PR uses the feature from JuliaLang/julia#41888 to test against the error text on 1.8 (since the exception type is just CapturedException).