Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate multiple component classes #9

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

sean-perkins
Copy link
Contributor

Resolves #5

The codemod was returning once the first component that matched the criteria was migrated, instead of migrating all the available components/files.

This was an oversight when refactoring and adding testing, where originally I was testing the returned result of the codemod function instead of looking at the source file contents after the migration.

@sean-perkins sean-perkins merged commit e9f4476 into main Oct 10, 2023
@sean-perkins sean-perkins deleted the sp/migrate-ionic-starter branch October 10, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Standalone page components are not migrated
1 participant