Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump iron to 0.6 #79

Merged
merged 3 commits into from
Nov 21, 2017
Merged

bump iron to 0.6 #79

merged 3 commits into from
Nov 21, 2017

Conversation

FauxFaux
Copy link
Contributor

@FauxFaux FauxFaux commented Nov 6, 2017

I'm getting some weird ICE with Iron 0.6 and it's not helping having body-parser and persistent pull in iron 0.5 as well as my iron 0.6, so.. let's just upgrade everything to 0.6?

I've confirmed that this will build after the persistent change is merged, but will probably ICE or give a weird error before then:

@untitaker
Copy link
Member

Same as iron/persistent#64 (comment)

If no API changes are necessary, could you instead set this to a "range" version? I.e something like >= 0.5.0, <0.7.0

Also travis fails?

@FauxFaux
Copy link
Contributor Author

FauxFaux commented Nov 7, 2017

Travis fails because it needs the persistent issue to be closed and released first.

@iori-yja
Copy link

iori-yja commented Nov 14, 2017

@FauxFaux Could you change the versions of persistent if 0.4.0 has been published?
And I think it is also needed to upgrade body-parser version itself, because if the version of dependencies has been upgraded while the version itself unchanged, then user of iron-0.5.* will gets confused.

@untitaker
Copy link
Member

Please bump persistent version

@iori-yja
Copy link

iori-yja commented Nov 15, 2017

@FauxFaux Could you change the body-parser version itself? If you override the version, there might be no way to use it with iron-5.*.

@iori-yja
Copy link

iori-yja commented Nov 15, 2017

And iron = "0.6" should be iron = ">= 0.5, < 0.7"

@shepmaster
Copy link

I'm getting some weird ICE

This should now be resolved in the current beta and nightly versions.

@robinst
Copy link

robinst commented Nov 16, 2017

@untitaker I think this is good to merge and release now.

@untitaker
Copy link
Member

untitaker commented Nov 21, 2017 via email

@robinst
Copy link

robinst commented Nov 21, 2017

Thank you!

@FauxFaux FauxFaux deleted the bump-iron branch November 21, 2017 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants