we now pass cwd around using env #1
Merged
+60
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bcoe
commented
May 9, 2015
bcoe
commented
- rather than hardcoding cwd, we now pass around the process.env.NYC_CWD variable:
- if process.env.NYC_CWD is not found, we assume this is a fresh run of the tool and: 1. delete the nyc_output directory, and 2. populate process.env.NYC_CWD with process.cwd()
- rather than requiring that patterns are configured for folders that we should apply coverage reports to, we now exclude specific folders (node_modules, test).
coreyfarrell
pushed a commit
to coreyfarrell/nyc
that referenced
this pull request
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.