Use absolute file paths in coverage #164
Conversation
|
And of course this broke a whole bunch of Windows tests. Will fix tomorrow. Also, weirdly, Travis doesn't seem to have picked up on this PR yet. |
|
@novemberborn womp womp, Travis has been running very slowly during the day. Thanks for tackling these difficult file path edge-cases, great work. I'm working on getting a major release of yargs out the door (which has some features I want for nyc) then I will be concentrating on getting a few releases of nyc out the door. |
|
@bcoe no worries. Maybe this is a good time to point out https://github.com/bcoe/nyc/blob/89098dbbcfe5880c152cba70c3100063c8ba99a9/package.json#L51:L60 is outdated? 😜 |
novemberborn
force-pushed
the
absolute-coverage-paths
branch
from
fe2d7ab to
d0b7b86
Compare
Pass an absolute path to the instrumenter. This results in the coverage containing absolute paths. Adjust caching and source map logic to use absolute paths. Rename variables. The change to the source map logic should let it handle source map sources that have absolute paths. Before these were joined to the file path, now the new path is resolved instead.
novemberborn
force-pushed
the
absolute-coverage-paths
branch
from
d0b7b86 to
1d53f10
Compare
|
@bcoe tests pass now. |
|
@novemberborn 👍 I've been pretty swamped this week, but will get a release of nyc out first thing this weekend. |
Use absolute file paths in coverage
Pass an absolute path to the instrumenter. This results in the coverage containing absolute paths.
Adjust caching and source map logic to use absolute paths. Rename variables.
The change to the source map logic should let it handle source map sources that have absolute paths. Before these were joined to the file path, now the new path is resolved instead.
Fixes #110.