Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add coverage to default excludes #23

Merged
merged 4 commits into from
Jan 19, 2017
Merged

fix: add coverage to default excludes #23

merged 4 commits into from
Jan 19, 2017

Conversation

JaKXz
Copy link
Member

@JaKXz JaKXz commented Jan 19, 2017 •
edited
Loading

Fixes istanbuljs/nyc#496.

@bcoe for completeness I would use the rebase and merge option for this PR.

@JaKXz JaKXz requested a review from bcoe January 19, 2017 00:14
@coveralls
Copy link

coveralls commented Jan 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8296396 on fix/coverage-default-excludes into cf979c7 on master.

@coveralls
Copy link

coveralls commented Jan 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f93feb5 on fix/coverage-default-excludes into cf979c7 on master.

@JaKXz
Copy link
Member Author

JaKXz commented Jan 19, 2017

@bcoe if we merge this first I can rebase #24 and ignore read-pkg-up :)

bcoe
bcoe approved these changes Jan 19, 2017
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, I think we should make this a major bump of the library since we're now ignoring an additional folder ... but I feel like this behavior is expected in nyc, so I don't think we need to bump a major upstream.

@bcoe bcoe merged commit 59e8bbf into master Jan 19, 2017
@bcoe bcoe deleted the fix/coverage-default-excludes branch January 19, 2017 06:37
@bcoe
Copy link
Member

bcoe commented Jan 19, 2017

@JaKXz done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaKXz @coveralls @bcoe