Skip to content

exp: use exp git remote for studio repo url #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Mar 7, 2024

Simplifies setting studio repo url per the suggestion here.

If DVC_EXP_GIT_REMOTE env var or dvc config exp.git_remote is set, the url for that remote will be set for sending updates to Studio and override DVC_STUDIO_REPO_URL/studio.repo_url (these can be deprecated and dropped in the future).

Closes #10137

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.67%. Comparing base (603da1c) to head (bd0c3cb).

Files Patch % Lines
dvc/utils/studio.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10345      +/-   ##
==========================================
- Coverage   90.67%   90.67%   -0.01%     
==========================================
  Files         500      500              
  Lines       38679    38700      +21     
  Branches     5591     5596       +5     
==========================================
+ Hits        35073    35092      +19     
- Misses       2963     2965       +2     
  Partials      643      643              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me.

@dberenbaum dberenbaum enabled auto-merge (rebase) March 11, 2024 14:25
@dberenbaum dberenbaum merged commit 7df58ce into main Mar 11, 2024
20 checks passed
@dberenbaum dberenbaum deleted the studio-exp-git-remote branch March 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc studio login: setup auto pushing experiments
3 participants