Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added auto rotate functionality #10

Merged
merged 2 commits into from
Nov 24, 2019

Conversation

thexmanxyz
Copy link
Contributor

Actually I just wanted to answer the question asked in #8. But it would be great to have that functionality directly in the project if someone wants to tinker around so im creating this PR. It's just trivial but why not.

@itsharryle
Copy link
Owner

@thexmanxyz Hi! Thanks for adding this feature. If you could fix the error on line 85 pointed out by parasm0802 I would be more than happy to merge this PR in. Thanks for your contribution.

@thexmanxyz
Copy link
Contributor Author

thexmanxyz commented Nov 24, 2019

@parasm0802 Strangely I did not get a notification email for your comment. I completely missed that compile error. Will add a commit in the next minutes to fix that compilation error. Just wrote it without checking syntax I guess. @VectStudio. Sorry for that. You can merge it in the next minutes.

@thexmanxyz
Copy link
Contributor Author

@VectStudio You are welcome! Sorry for adding a compilation error. I now verified the sketch and added another commit which adds the missing ) bracket. I'm curious why I did not get a notification mail on August 16th for the comment from @parasm0802 not even in my mail history. But whatever it is fixed now. Thanks in advance for merging!

@itsharryle itsharryle merged commit c76348b into itsharryle:master Nov 24, 2019
@thexmanxyz thexmanxyz deleted the feature/auto_rotate branch November 26, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants