-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable a more interactive CLI via Liner #69
Conversation
…istory and the user to iterate through that history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
Do you know if it happens to support piped stdin like if people are cat'ing a file of commands into rcon-cli? I'm not sure if that's a common use case, so probably not a problem if not supported.
I didn't even think of that as a use case, I'll spin up an environment and play with it a bit. |
Looks like it handles it, at least as I'd expect it too echo -e "time set day\ndeop Ser_Luke\nlist" | ./rcon-cli --password <omitted>
|
Thanks for checking that. |
Included in this image build: https://github.com/itzg/docker-minecraft-server/actions/runs/13742852242 |
You might also be able to close #10, if you just wanted the history. Although this patch only preserves history for the lifetime of the interactive session (would need to write to a file for longer) |
Thanks, yeah seems fair to close that one due to this change. |
Add liner as a dependency, and enable the interactive cli to have a history and the user to iterate through that history
Should provide the functionality requested in: #60, but doesn't use the library in question.
I'll also note, this is my first time working in go, so I'm more than happy for any input.