Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skipped content type validation for GET requests #28

Merged
merged 4 commits into from
Oct 11, 2022
Merged

fix: skipped content type validation for GET requests #28

merged 4 commits into from
Oct 11, 2022

Conversation

noureentaj
Copy link
Contributor

Fixed Content-Type validation for GET requests

@noureentaj noureentaj self-assigned this Oct 5, 2022
@noureentaj noureentaj requested a review from iudeen October 5, 2022 14:21
iudeen
iudeen requested changes Oct 5, 2022
View reviewed changes
Copy link
Owner

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just stick to POST. Not sure if other methods like FETCH will have content type headers.

@noureentaj noureentaj requested a review from iudeen October 5, 2022 17:23
@noureentaj noureentaj requested review from iudeen and removed request for iudeen October 8, 2022 12:36
iudeen
iudeen reviewed Oct 8, 2022
View reviewed changes
Copy link
Owner

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests are failing due to long check.

@noureentaj noureentaj merged commit 9f0f06a into iudeen:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iudeen iudeen iudeen approved these changes

Assignees

@noureentaj noureentaj

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noureentaj @iudeen