Skip to content

Support stack_ fun #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2025
Merged

Support stack_ fun #103

merged 3 commits into from
Feb 28, 2025

Conversation

riaqn
Copy link

@riaqn riaqn commented Feb 14, 2025

This PR is to accomodate compiler parser changes in ocaml-flambda/flambda-backend#3106

@riaqn riaqn marked this pull request as draft February 14, 2025 17:31
@riaqn
Copy link
Author

riaqn commented Feb 14, 2025 •
edited
Loading

This is currently blocked by two issues:

  • -x is not simple_expr in parser, but parsed as Pexp_prefix and thus counts as Exp.is_simple_in_parser. This is fixed by the last commit.
  • STACK has too high priority - in particular, stack_ c#x should not parse as (stack_ c) # x. This needs to be fixed in the compiler parser first. Fix stack_ precedence ocaml-flambda/flambda-backend#3583

@riaqn riaqn mentioned this pull request Feb 17, 2025
Merged
@riaqn riaqn force-pushed the stack-fun-no-paren branch from 03d397f to bc394fc Compare February 25, 2025 16:32
@riaqn riaqn marked this pull request as ready for review February 25, 2025 16:33
riaqn added 3 commits February 25, 2025 16:35
@riaqn
run repatch.sh
ad79531 
Signed-off-by: Zesen Qian <[email protected]>
@riaqn
stack_ fun
3f53017 
Signed-off-by: Zesen Qian <[email protected]>
@riaqn
fix is_simple_in_parser for uminus and uplus
a3390e7 
Signed-off-by: Zesen Qian <[email protected]>
@riaqn riaqn force-pushed the stack-fun-no-paren branch from bc394fc to a3390e7 Compare February 25, 2025 16:35
@riaqn
Copy link
Author

riaqn commented Feb 25, 2025

Ready for review now - please review by commits.

@riaqn riaqn requested a review from dvulakh February 25, 2025 16:36
dvulakh
dvulakh approved these changes Feb 28, 2025
View reviewed changes
Copy link

@dvulakh dvulakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. I tested against the codebase internally --- it's a nice diff to read :)

@riaqn riaqn merged commit e918d32 into jane Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvulakh dvulakh dvulakh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riaqn @dvulakh