Skip to content
This repository was archived by the owner on May 28, 2018. It is now read-only.

added @Priority handling to exception mappers; resolves JERSEY-2437; #265

Closed
wants to merge 1 commit into from

Conversation

sdaschner
Copy link

This adds handling of @Priority annotations on ExceptionMappers as issued in JERSEY-2437 and JAX_RS_SPEC-532.

@pavelbucek
Copy link
Member

Existing tests don't pass and there are no added tests.

Don't get me wrong, I appreciate the effort, but if you just have an idea about how something could be solved, please add them as a comment to a jira issue.

@pavelbucek pavelbucek closed this Apr 14, 2017
@sdaschner
Copy link
Author

Yes, I know, sorry for that. The tests didn't run locally on my machine even before the commit, so I couldn't verify the changes :/

@sdaschner
Copy link
Author

Is there some extra effort required to run the (integration) tests locally? I would be happy to contribute that feature properly, but without executing tests it's a little bit hard :-)

@pavelbucek
Copy link
Member

no, you should be able to execute "mvn clean install" on freshly downloaded sources.

Anyway, don't mind this issue any more, I'll take care of it (re-evaluating pull requests would most likely consume more time than doing the implementation.. if I'll be able to make it backwards compatible).

@sdaschner
Copy link
Author

Ok, yes mvn clean install from scratch didn't work last time. Anyway, sorry again.

@bric3
Copy link

bric3 commented Oct 9, 2017

@pavelbucek any news on this ?

@pavelbucek
Copy link
Member

@bric3 not sure what you mean - this feature is included in JAX-RS 2.1 and Jersey 2.26. (actually, we did make all provider ordering respect @priority annotation..)

@chkal
Copy link

chkal commented Oct 9, 2017

@bric3 If you tried to use @Priority on exception mappers and it didn't work, have a look at #3670 which I created some time ago. The issue is about param converters, but I'm pretty sure exception mappers are also affected.

@bric3
Copy link

bric3 commented Oct 14, 2017

@pavelbucek I didn't know it was included in 2.26, and I missed the new section §4.1.3 of the 2.1 specification (the migrated issues on github are not assigned to any milestone)

@chkal Interesting issue, it may be relevant for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants