Support Django 5.2 #260
Support Django 5.2 #260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 76 75 -1
Branches 18 18
=========================================
- Hits 76 75 -1 ☔ View full report in Codecov by Sentry. |
First, Mypy reported a lot of issues for the tests not including `-> None` annotations. After adding them, there were lots of issues due to the `url` variables being reassigned from `str` to `DBConfig` objects, fixed by inlining the URLs into the `parse()` calls.
adamchainz
force-pushed
the
django_5.2
branch
from
53e5247 to
597b493
Compare
| @@ -32,7 +39,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| pip install -r requirements.txt | |||
| pip install "Django~=${{ matrix.django-version }}.0" . | |||
| pip install "django~=${{ matrix.django-version }}.0a1" . | |||
There was a problem hiding this comment.
Why the 0a1 bit? Won't that make this install alpha releases?
There was a problem hiding this comment.
Ah. I hadn't realised 5.2 was an alpha. I don't think we should be doing this yet, as we can't guarantee just because we support a 5.2 alpha that we'll definitely work with the released version. Happy to merge this (without the alpha install change) the moment it's released, but not before.
There was a problem hiding this comment.
Okay, fair enough. At least I know dj-database-url works without any changes.
The first commit adds Django 5.2 support - no code changes required, just adding the testing and metadata.
The second commit fixes all type errors reported by Mypy, which are probably due to a new Mypy version being released. I extracted this into a second PR which should be merged first: #261.