Skip to content

fix: auto generate spring-configuration-metadata.json #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

imp2002
Copy link
Member

@imp2002 imp2002 commented Sep 22, 2022

image

The configuration for tableName is miss in spring-configuration-metadata.json lead to this. But we don't need maintain spring-configuration-metadata.json in src/resource.

When build project, the spring-configuration-metadata.json will be generated auto, use spring-boot-configuration-processor.

image

@casbin-bot
Copy link

@tangyang9464 please review

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 58.06% // Head: 53.55% // Decreases project coverage by -4.51% ⚠️

Coverage data is based on head (041ca61) compared to base (1aadca5).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     58.06%   53.55%   -4.52%     
+ Complexity      100       37      -63     
============================================
  Files            17       11       -6     
  Lines           434      183     -251     
  Branches         41       11      -30     
============================================
- Hits            252       98     -154     
+ Misses          153       73      -80     
+ Partials         29       12      -17     
Impacted Files Coverage Δ
...oot/autoconfigure/properties/CasbinProperties.java 70.17% <50.00%> (-1.76%) ⬇️
...a/org/casbin/exception/CasbinAdapterException.java 0.00% <0.00%> (-20.00%) ⬇️
...configure/CasbinRedisWatcherAutoConfiguration.java 85.71% <0.00%> (-14.29%) ⬇️
src/main/java/org/casbin/adapter/CasbinRule.java
src/main/java/org/casbin/watcher/RedisWatcher.java
...ain/java/org/casbin/adapter/PostgreSQLAdapter.java
src/main/java/org/casbin/adapter/JdbcAdapter.java
src/main/java/org/casbin/adapter/DB2Adapter.java
...rc/main/java/org/casbin/adapter/OracleAdapter.java
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hsluoyz hsluoyz merged commit cf227ac into jcasbin:master Sep 25, 2022
@github-actions
Copy link

🎉 This PR is included in version 0.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants