Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CLI Integration Tests and Preferring named exports #711

Merged
merged 54 commits into from
Apr 23, 2020
Merged

Adding CLI Integration Tests and Preferring named exports #711

merged 54 commits into from
Apr 23, 2020

Conversation

jdalrymple
Copy link
Owner

Sister PR to #709 while investigating #710

@jdalrymple jdalrymple added the bug label Apr 22, 2020
@jdalrymple jdalrymple force-pushed the cli-integration-tests branch from ca0fd00 to daca122 Compare April 22, 2020 14:27
jdalrymple added 25 commits April 22, 2020 21:25
@jdalrymple
Add suite of integration tests
b44d239
@jdalrymple
Add back one integration script
e036c26
@jdalrymple
Adding some type information and switching to named exports
e3a74be
@jdalrymple
Updating browser integration tests
ecad973
@jdalrymple
Updating lock
ff7293d
@jdalrymple
Export modify function the requester-utils
4e509c1
@jdalrymple
Should return a dictionary of modified constructors
03235e5
@jdalrymple
cleaning up rebase
e9899cf
@jdalrymple
Add suite of integration tests
30a4a0f
@jdalrymple
Updating lock
78d4e7d
@jdalrymple
Export modify function the requester-utils
cc0eb35
@jdalrymple
Update contributors [skip ci]
557866c
@jdalrymple
Linting [skip ci]
122a958
@jdalrymple
Adding back cli integration tests
61b05c5
@jdalrymple
Rebase to ensure import is named not default
1832e13
@jdalrymple
Fix binary path in tests
20c8310
@jdalrymple
Verify node is available
6ea3e30
@jdalrymple
Fixing binary path
5a1a354
@jdalrymple
Renaming the tests, adding some console logs for debugging
0626c40
@jdalrymple
Why is this crashing
d267e62
@jdalrymple
Fixing up path reference and browser integration test cli config
7623f07
@jdalrymple
Fixing jest config
6d184ad
@jdalrymple
Updating license import
7606bf7
@jdalrymple
Fixing errors with jest config
df297e1
@jdalrymple
Are build files available?
bda789d
@jdalrymple jdalrymple force-pushed the cli-integration-tests branch from 3c06778 to 7ca1c29 Compare April 22, 2020 20:56
@jdalrymple
Copy link
Owner Author

True!!!!!!!!!!!! That would make sense. I wonder why that doesn't happen locally though, also why it works for one of the tests but not others.

Answered by own question. the version check doesnt use the custom env

@jdalrymple
Copy link
Owner Author

New random error: https://gitlab.com/jdalrymple/gitbeaker/-/jobs/523978110#L37

@jdalrymple jdalrymple merged commit c4522e2 into master Apr 23, 2020
@jdalrymple jdalrymple deleted the cli-integration-tests branch April 23, 2020 21:34
@jdalrymple jdalrymple added breaking and removed bug labels Apr 23, 2020
@jdalrymple jdalrymple changed the title Adding CLI Integration Tests Adding CLI Integration Tests and Preferring named exports Apr 23, 2020
@jdalrymple
Copy link
Owner Author

🚀 PR was released in 19.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdalrymple @jetersen