Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stalled RenderAhead #25

Merged
merged 3 commits into from
May 15, 2022
Merged

Conversation

dmitrylyzo
Copy link
Collaborator

The implementation of libass#111 (comment) + libass#111 (comment)

Changes

  • Display last available frame
  • Request frames with extra time

Issues
If the worker can't render fast enough, the canvas doesn't get updates because new frames are already outdated.

@dmitrylyzo dmitrylyzo force-pushed the oneshot-unstall branch 2 times, most recently from 7eb7518 to 6314c99 Compare May 6, 2022 20:54
@dmitrylyzo dmitrylyzo force-pushed the oneshot-unstall branch 2 times, most recently from f2dfaac to 4cf8ffa Compare May 7, 2022 23:02
@dmitrylyzo dmitrylyzo changed the title Unstall RenderAhead Fix stalled RenderAhead May 7, 2022
@dmitrylyzo dmitrylyzo added the bug Something isn't working label May 8, 2022
If the worker can't render fast enough, the canvas doesn't
get updates because new frames are already outdated. So we
display the last available frame until it is replaced by a
new one.
@dmitrylyzo dmitrylyzo marked this pull request as ready for review May 14, 2022 21:40
@dmitrylyzo
Copy link
Collaborator Author

The nextRequestOffset estimate is not the best, but it works,.. more or less. 😅

@dmitrylyzo dmitrylyzo merged commit ddb93df into jellyfin:new-master May 15, 2022
@dmitrylyzo dmitrylyzo deleted the oneshot-unstall branch May 15, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant