Upgrade to new jcasc test harness #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Jan 14, 2020
...test/java/com/microsoftopentechnologies/windowsazurestorage/helper/CredentialRenameTest.java
Show resolved
Hide resolved
...test/java/com/microsoftopentechnologies/windowsazurestorage/helper/CredentialRenameTest.java
Show resolved
Hide resolved
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
|
|
||
| public class CredentialRenameTest { | ||
| public static File input = new File("src/test/resources/com/microsoftopentechnologies/helper/correctFormatOldConfig.xml"); | ||
| private Jenkins jenkinsInstance; | ||
| private static final String correctConfigContent = |
There was a problem hiding this comment.
on new credentials it seems like the credential.xml was cached in memory and credentials weren't being loaded by just overwriting it on the file system
|
|
||
| CredentialRename.renameStorageConfig(); |
There was a problem hiding this comment.
this is called on startup, no need to call it again
|
Would be great to get a release with this in, so it can be used in PCT @gavinfish 😄 |
timja
commented
Jan 14, 2020
| @@ -93,7 +93,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>credentials</artifactId> | |||
| <version>2.1.16</version> | |||
| <version>2.2.0</version> | |||
There was a problem hiding this comment.
The credentials configurator moved to the credentials plugin from the support plugin in this version
Sure, I will draft a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCasc had to create a new dependency that wasn't a
testsclassifier because maven doesn't allow you to bring dependencies through classifiers.Upgrading here so that PCT works again,
Tracking:
jenkinsci/bom#164