Skip to content

Check git client 6.1.1 test fix for CLI git 2.48.0 #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jan 14, 2025

Check git client 6.1.1 test fix for CLI git 2.48.0

Work in progress. Do not merge. Running weekly test to confirm that the test fix in git client 6.1.1 is enough to fix the 3 tests that are failing with CLI git 2.48.0.

CLI git 2.48.0 changes a behavior that one of the git client tests unintentionally relied upon. The git client plugin test has been updated in the pull request and confirmed that it is passing with CLI git 2.48.0.

Testing done

Checked the plugin tests in the plugin repository. Checked that the git client plugin tests pass locally for me in BOM. Rely on ci.jenkins.io to test the rest of BOM.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
CLI git 2.48.0 changed a minor behavior that was unintentionally being
checked by the tests in the git client plugin.  The git client plugin
test has been modified to adapt to the behavior of CLI git 2.48.0 and
later.
CLI git 2.48.0 changes a behavior that one of the git client tests
unintentionally relied upon. The git client plugin test has been
updated in the pull request and confirmed that it is passing with CLI
git 2.48.x.
@MarkEWaite MarkEWaite changed the title Check git client test fix for CLI git 2.48.0 Check git client 6.1.1 test fix for CLI git 2.48.0 Jan 15, 2025
@MarkEWaite
Copy link
Contributor Author

The WorkflowTest.demo fix is in:

The ec2 plugin failure is related to artifact caching proxy and is transient.

Closing the plugin.

@MarkEWaite MarkEWaite closed this Jan 15, 2025
@MarkEWaite MarkEWaite deleted the check-git-client-test-fix branch January 15, 2025 14:42
@jglick
Copy link
Member

jglick commented Jan 15, 2025

#4204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants