Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert versioncolumn 319.x upgrade #4234

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

MarkEWaite
Copy link
Contributor

Revert versioncolumn 319.x upgrade

Test failures reported during BOM release, including:

  • hudson.plugin.versioncolumn.VersionMonitorTest.testMonitor_VersionIsNull_NotIgnored
  • hudson.plugin.versioncolumn.VersionMonitorTest.testMonitor_DifferentVersion_NotIgnored

This reverts commit 942ab4a.

Testing done

Confirmed that I see the test failure locally before this change and that the test passes after this change. Command line to run the test is:

PLUGINS=versioncolumn LINE=weekly TEST=VersionMonitorTest bash ./local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…43.vda_c20eea_a_8a_f to 319.v052e2d416b_23 in /bom-weekly (jenkinsci#4230)"

Test failures reported during BOM release, including:

* hudson.plugin.versioncolumn.VersionMonitorTest.testMonitor_VersionIsNull_NotIgnored
* hudson.plugin.versioncolumn.VersionMonitorTest.testMonitor_DifferentVersion_NotIgnored

This reverts commit 942ab4a.
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 17, 2025 19:16
@MarkEWaite MarkEWaite added the bug Something isn't working label Jan 17, 2025
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darinpope darinpope enabled auto-merge (squash) January 17, 2025 19:49
@darinpope darinpope merged commit 70ccaf3 into jenkinsci:master Jan 17, 2025
5 checks passed
@MarkEWaite MarkEWaite deleted the revert-versioncolumn-update branch February 5, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants