Avoid cleanup failures in GitStatusTest & GitSCMTest #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
force-pushed
the
fix-GitStatus-test-failures
branch
2 times, most recently
from
87714ed to
9df2af9
Compare
Parent pom 2.54 includes a Jenkins Test Harness version which no longer hides exceptions on test cleanup. Rather than spending enormous effort identifying why build log files are still open at the end of a test on ci.jenkins.io, apply workarounds specific to ci.jenkins.io which either skip the tests or apply additional workarounds in hopes the tests will pass. The GitStatusTest fails on ci.jenkins.io Windows agents when attempting to remove a build log file. The test uses notifyCommit in a mocked environment with JenkinsRule. That seems to leave the build log busy even after the test completes. Skip those tests on Windows when running on ci.jenkins.io. Run them in all other locations. They pass consistently on the 4 Windows machines in my CI cluster, but fail too frequently on ci.jenkins.io. The GitSCMTest fails on ci.jenkins.io Windows agents when attempting to remove a build log file. On ci.jenkins.io Windows computers, wait up to 5 seconds for the JenkinsRule instance to be idle before exiting the specific test. I hope that will reduce the intermittent failures without requiring that all methods in the test are disabled.
MarkEWaite
force-pushed
the
fix-GitStatus-test-failures
branch
from
557244e to
f92e0a3
Compare
MarkEWaite
changed the title
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid cleanup failures in GitStatusTest & GitSCMTest
GitSCMTest and GitStatusTest both fail intermittently on ci.jenkins.io Windows computers. The failures are due to a busy log file or a busy job directory. The failures are not due to busy git files or busy git directories. I assume some component is holding a file open at that point in the test.
Rather than spend significant time trying to find the component of JenkinsRule that is holding the build log open, it is simpler to use a "sleep" variant in one test and to skip the tests on the ci.jenkins.io Windows computers in the other test.
Tests continue to execute when run by developers. Tests continue to execute in my Windows and Linux and FreeBSD test environment.
Checklist
Types of changes