Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make branchesAlwaysIncludedRegex parameter not required #399

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Feb 9, 2024

fixes the #376 as it introduced a required parameter that is not required.
This also fixes nullability and allows the pattern not to be used when string is empty.

Testing done

Submitter checklist

Preview Give feedback

Unverified

This user has not yet uploaded their public signing key.
@jetersen jetersen added the bug Something isn't working label Feb 9, 2024
@jetersen jetersen enabled auto-merge (squash) February 9, 2024 19:58
@jetersen jetersen changed the title Fix required parameter to non required Make branchesAlwaysIncludedRegex parameter not required Feb 9, 2024

Unverified

This user has not yet uploaded their public signing key.
@jetersen jetersen merged commit de45e0b into master Feb 9, 2024
14 of 15 checks passed
@jetersen jetersen deleted the fix/376 branch February 9, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant