Skip to content
/ jenkins Public

Bump jenkins-test-harness to 2.56 #4301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Bump jenkins-test-harness to 2.56 #4301

wants to merge 3 commits into from
+33 −3

Conversation

slonopotamus
Copy link
Contributor

This PR is expected to reveal bogus Windows tests that do not shutdown things properly. See jenkinsci/jenkins-test-harness#166

Proposed changelog entries

None

@slonopotamus
Copy link
Contributor Author

Err... Windows CI is still not working?

@oleg-nenashev oleg-nenashev added internal skip-changelog Should not be shown in the changelog labels Oct 18, 2019
@oleg-nenashev
Copy link
Member

@slonopotamus Yes, it is still disabled

@oleg-nenashev
Copy link
Member

#4155 FTR

@slonopotamus slonopotamus force-pushed the jenkins-test-harness-2.56 branch from ad5d6fc to e903880 Compare October 18, 2019 13:09
@slonopotamus slonopotamus reopened this Oct 18, 2019
@slonopotamus slonopotamus force-pushed the jenkins-test-harness-2.56 branch from e903880 to d324bce Compare October 18, 2019 16:07
@slonopotamus
Copy link
Contributor Author

Seems like Linux CI is also broken now.

@timja timja closed this Oct 19, 2019
@timja timja reopened this Oct 19, 2019
@slonopotamus slonopotamus reopened this Oct 22, 2019
@slonopotamus
Copy link
Contributor Author

Do not merge this until Windows CI is working again because this PR is expected to break tests that worked otherwise.

@timja timja added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Oct 22, 2019
oleg-nenashev
oleg-nenashev reviewed Oct 22, 2019
View reviewed changes
pom.xml
@@ -91,6 +91,7 @@ THE SOFTWARE.
<project.patchManagement.url>https://api.github.com</project.patchManagement.url>
<patch.tracker.serverId>jenkins-jira</patch.tracker.serverId>

<hamcrest.version>2.1</hamcrest.version>
<matrix-auth.version>2.3</matrix-auth.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use dependencyManagement instead?

Copy link
Contributor Author

@slonopotamus slonopotamus Oct 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkins-test-harness doesn't do that, why do this here differently?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code, but no strong opinion

@timja timja removed the on-hold This pull request depends on another event/release, and it cannot be merged right now label Oct 23, 2019
@timja timja closed this Oct 23, 2019
@timja timja reopened this Oct 23, 2019
@timja
Copy link
Member

timja commented Oct 23, 2019

Windows CI is re-enabled, re-triggering

@slonopotamus
Copy link
Contributor Author

Nice. As I expected, some things failed. I plan to fix them within this PR.

@slonopotamus slonopotamus force-pushed the jenkins-test-harness-2.56 branch from d324bce to 5315b9d Compare October 24, 2019 06:31
@slonopotamus
Force garbage collection after stopping plugins
7e92923 
Java doesn't have any direct means to release unreferenced classloaders,
so we force GC to do that so it becomes possible to delete plugin jar on Windows.
@slonopotamus slonopotamus force-pushed the jenkins-test-harness-2.56 branch from 2865d66 to 7e92923 Compare October 24, 2019 12:07
@alecharp alecharp added the work-in-progress The PR is under active development, not ready to the final review label Oct 24, 2019
@alecharp
Copy link
Member

I added the label WIP based on your latest comment @slonopotamus. Thank you for noticing the problem.

@oleg-nenashev
Copy link
Member

Ready to go @slonopotamus ?

oleg-nenashev
oleg-nenashev approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, because the issues seem to be fixed

@slonopotamus
Copy link
Contributor Author

This PR only seems to be fixed because Windows CI is disabled.

@timja timja added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Nov 12, 2019
@slonopotamus
Copy link
Contributor Author

JTH was already upgraded to 2.57 in #4392

@slonopotamus slonopotamus deleted the jenkins-test-harness-2.56 branch December 17, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev

Assignees
No one assigned
Labels
internal on-hold This pull request depends on another event/release, and it cannot be merged right now skip-changelog Should not be shown in the changelog work-in-progress The PR is under active development, not ready to the final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slonopotamus @oleg-nenashev @timja @alecharp