Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed one typo & image position in README #157

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fixed one typo & image position in README #157

merged 2 commits into from
Jan 15, 2025

Conversation

PratikMane0112
Copy link
Contributor

Fixed one typo & image position in README.md

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@PratikMane0112 PratikMane0112 requested a review from a team as a code owner January 15, 2025 17:49
nfalco79
nfalco79 reviewed Jan 15, 2025
View reviewed changes
README.md Outdated
You can also choose if enable or not the support for npm 9+ version.
5. You would relocate the npm cache folder to swipe out it when a job
6. You would relocate the npm cache folder to swipe out it when a job
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is point 5?

@PratikMane0112
Copy link
Contributor Author

Just given space below image, nothing updated w.r.t points, My branch README ss -

Screenshot 2025-01-16 001626

@nfalco79
Copy link
Member

I have not done any changes w.r.t points, it is still there in my updated README in my new branch. Below is the ss of it

Screenshot 2025-01-16 001000

maybe github render ol list with own numbers anyway in the source you changed 5 with 6 as you can see from commit diff

@PratikMane0112
Copy link
Contributor Author

I have not done any changes w.r.t points, it is still there in my updated README in my new branch. Below is the ss of it
Screenshot 2025-01-16 001000

maybe github render ol list with own numbers anyway in the source you changed 5 with 6 as you can see from commit diff

Yes, I see

@nfalco79 nfalco79 merged commit f93fe17 into jenkinsci:master Jan 15, 2025
1 of 3 checks passed
@PratikMane0112
Copy link
Contributor Author

Thanks you sir for merging !!!!

@PratikMane0112 PratikMane0112 deleted the typo-and-image-position branch January 17, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfalco79 nfalco79 nfalco79 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PratikMane0112 @nfalco79