Don't automatically mark the parent job as SUCCESS #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds a nice. Any simple test to ensure this doesn't get change in the future? |
hashar
added a commit
to hashar/parameterized-trigger-plugin
that referenced
this pull request
Apr 10, 2024
I keep having log messages such as: WARNING: [hudson.plugins.parameterizedtrigger.TriggerBuilder perform] Attempting to use the result of unfinished build <name of job> #1234 The message was introduced in jenkinsci#161 by 06d8f19 but in jenkinsci#148 / 02ee6ea, mapBuildResult() was made to return `null` by default (eg on SUCCESS). The resut is the warning is always triggered when the triggered build succeeds. Fixes https://phabricator.wikimedia.org/T336782
MarkEWaite
added a commit
that referenced
this pull request
May 7, 2024
I keep having log messages such as: WARNING: [hudson.plugins.parameterizedtrigger.TriggerBuilder perform] Attempting to use the result of unfinished build <name of job> #1234 The message was introduced in #161 by 06d8f19 but in #148 / 02ee6ea, mapBuildResult() was made to return `null` by default (eg on SUCCESS). The resut is the warning is always triggered when the triggered build succeeds. Fixes https://phabricator.wikimedia.org/T336782 Co-authored-by: Mark Waite <[email protected]> Co-authored-by: Bruno Verachten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this plugin is used to call another job during the build or pre-scm build stages, and the user chooses to block on the job until it's completed, this plugin sets the parent job status to "SUCCESS", even though there should be no assumption that the success of the child job mandates success of the parent job.
Example:
This can cause strange issues in a few cases; for example, the extended e-mail notifier plugin can send e-mails at various stages, including "immediately before the build starts". We have an e-mail template that goes out to developers, and we include ${BUILD_STATUS} in the template, but because of this behaviour in this plugin, the "Your build has started" e-mail tells them that the build is a success; when they go to view the job, it's not finished, and they're left wondering why they got an e-mail saying success when it's not successful.
While the user can customize marking the build as failed, as a failure, or as unstable, there's no option for the user to choose to mark the current build as success; furthermore, I don't think that marking the build as a success so early in the build process necessarily makes sense, but I could be mistaken.