Require 2.479.1 or newer #235
Conversation
src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/BasicSSHUserPassword.java
Show resolved
Hide resolved
| <!-- Last 2.426.x BOM version before a trilead api upgrade --> | ||
| <!-- Trilead API upgrade breaks plugin compatibility tests due to poor handling of optional dependencies --> | ||
| <!-- Do not change this without checking plugin BOM passes with new version --> | ||
| <!-- https://github.com/jenkinsci/bom/pull/3404 --> |
There was a problem hiding this comment.
jenkinsci/bom#3404 obsolete I hope?
There was a problem hiding this comment.
@MarkEWaite you added this comment in #212. I lack any context for the problem.
There was a problem hiding this comment.
I think that the BOM contributing guide describes the problem as:
Failed to load - update required
This message usually shows that an optional dependency of a plugin is not being updated by the Plugin Compatibility Tester (PCT) and that update is needed by another plugin.
That section includes more details and links to pull requests that have adapted to the issue.
There was a problem hiding this comment.
I confirmed that the incremental build 354.v22ca_383c6973 from this branch passes PCT with this command:
LINE=weekly PLUGINS=ssh-credentials TEST=InjectedTest bash local-test.sh
The change I locally applied was:
diff --git a/bom-weekly/pom.xml b/bom-weekly/pom.xml
index 9dc987f6..8c8996cf 100644
--- a/bom-weekly/pom.xml
+++ b/bom-weekly/pom.xml
@@ -1471,7 +1471,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>ssh-credentials</artifactId>
- <version>349.vb_8b_6b_9709f5b_</version>
+ <version>354.v22ca_383c6973</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Removing that old comment looks right to me. Thanks!
|
Pull request needs to be labeled "feature" or "developer" or "rfe" in order to create a new release. |
|
Labeling it after the fact does not produce a release, unless another PR is merged later. In general, if a PR of this type needs a release in a timely fashion (for example to resolve some issue with |
Thanks! I'd like a manual release of this plugin so that the Spring Security 6.x cleanup work can continue its forward progress. It is not a critical need, but it will help us continue to make progress. |
No description provided.