Proposal fix for Improvement JENKINS-3034 - pegging of externals when tagging

[jedes]

Hi,

Here is a proposal fix for issue JENKINS-3034, which adds the option of pegging externals when tagging. The source of the svn copy (when the option is turned on) is the local working copy.

[buildhive]

Jenkins » svn-tag-plugin #2 SUCCESS
This pull request looks good
(what's this?)

[buildhive]

Jenkins » svn-tag-plugin #3 SUCCESS
This pull request looks good
(what's this?)

[buildhive]

Jenkins » svn-tag-plugin #4 SUCCESS
This pull request looks good
(what's this?)

[buildhive]

Jenkins » svn-tag-plugin #5 SUCCESS
This pull request looks good
(what's this?)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[dp-gua]

Thank you for your efforts. We use this version of the svn-tag-plugin successfully on our master instance. But it doesn't work on the slave because of a NotSerializableException:

ERROR: Publisher org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher aborted due to exception
hudson.util.IOException2: remote file operation failed: /homes/jenkins/workspace/Test at hudson.remoting.Channel@8f9bc65:slavetest
at hudson.FilePath.act(FilePath.java:901)
at hudson.FilePath.act(FilePath.java:878)
at hudson.plugins.svn_tag.SvnTagPlugin.perform(SvnTagPlugin.java:200)
at hudson.plugins.svn_tag.SvnTagPublisher.perform(SvnTagPublisher.java:86)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner$DontRun.conditionalRun(BuildStepRunner.java:264)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105)
at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:88)
at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:96)
at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:36)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:804)
at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:776)
at hudson.model.Build$BuildExecution.post2(Build.java:183)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:726)
at hudson.model.Run.execute(Run.java:1618)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:242)
Caused by: java.io.IOException: Unable to serialize hudson.FilePath$FileCallableWrapper@631e133f
at hudson.remoting.UserRequest.serialize(UserRequest.java:166)
at hudson.remoting.UserRequest.(UserRequest.java:62)
at hudson.remoting.Channel.call(Channel.java:721)
at hudson.FilePath.act(FilePath.java:894)
... 17 more
Caused by: java.io.NotSerializableException: org.tmatesoft.svn.core.wc.SVNCopyClient
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1180)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1528)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1493)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1416)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1174)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1528)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1493)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1416)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1174)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:346)
at hudson.remoting.UserRequest._serialize(UserRequest.java:155)
at hudson.remoting.UserRequest.serialize(UserRequest.java:164)
... 20 more

Is there any way to fix this?

[jedes]

I ran into the same problem at first but it has been fixed. There is more than one commit in the GIT branch. Ensure you have the latest. It is working as expected for me on master/slave deployments

[buildhive]

Jenkins » svn-tag-plugin #6 ABORTED

(what's this?)

[dp-gua]

We are using "Subversion Tagging Plugin 1.17-SNAPSHOT (private-06/12/2013 01:15-jenkins)" - IMO build #5. Is there any configuration or dependency we have to consider?

Our Subversion Plug-in:
org.jenkins-ci.plugins:subversion:1.50
org.jenkins-ci.svnkit:svnkit:1.7.6-jenkins-2
org.tmatesoft.sqljet:sqljet:1.1.0
de.regnis.q.sequence:sequence-library:1.0.1
org.antlr:antlr-runtime:3.4

Jenkins ver. 1.519

[jedes]

Sorry, my bad: there were leftover differences in my working folder that I hadn't committed & pushed. Hopefully the latest build will be functional.

[buildhive]

Jenkins » svn-tag-plugin #7 SUCCESS
This pull request looks good
(what's this?)

[dp-gua]

After I installed the plugin Jenkins could not read the configuration of all jobs that use the plugin. (I'm sorry, but I have no specific error message. And due to the fact that we only have a production system, I would not update the plugin again.) Do I have to change the configuration manual?

[jedes]

Humm... I did change the jelly file, so such a behaviour is possible. I'd have to do more testing to be sure...

[jedes]

I reproduced you problem: it is just that the latest build of the svn-tagging plugin is now dependant on the scm-api plugin (You can get it from http://updates.jenkins-ci.org/download/plugins/scm-api/). Since svn-tagging fails to load, the entries in the configuration pages don't show up. Once you install scm-api, everything should be back to normal...

[buildhive]

Jenkins » svn-tag-plugin #8 SUCCESS
This pull request looks good
(what's this?)

[cloudbees-pull-request-builder]

plugins » svn-tag-plugin #1 SUCCESS
This pull request looks good

[oleg-nenashev]

The change seems to be reasonable after 3 years, but a massive re-merge is required