Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API version to 2.1.0. #3220

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

ossy-szeged
Copy link
Contributor

@ossy-szeged ossy-szeged commented Oct 16, 2019

Closes #3104.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: IMHO "Closes #3104" would look better in the commit message, as the referenced issue is not a bug to be fixed.

@ossy-szeged
Copy link
Contributor Author

Minor comment: IMHO "Closes #3104" would look better in the commit message, as the referenced issue is not a bug to be fixed.

Good point, I fixed the commit message.

Closes jerryscript-project#3104.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit e8bc7a2 into jerryscript-project:master Oct 16, 2019
@ossy-szeged ossy-szeged deleted the update-api-version branch October 22, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning and Release Cadence Plans
4 participants