Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[Prototype]] object's reference count should be increased by jerry_get_prototype #3550

Merged

Conversation

rerobika
Copy link
Member

@rerobika rerobika commented Feb 7, 2020

This patch ensures that the implementation satisfies the requirements of the public API documentation.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

…et_prototype

This patch ensures that the implementation satisfies the requirements of the public API documentation.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
@rerobika rerobika added the api Related to the public API label Feb 7, 2020
@rerobika rerobika requested review from dbatyai and galpeter February 7, 2020 15:50
@dbatyai dbatyai added the bug Undesired behaviour label Feb 7, 2020
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dbatyai dbatyai merged commit 5fdeb7c into jerryscript-project:master Feb 7, 2020
@rerobika rerobika deleted the api_fix_get_prototype_of branch June 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the public API bug Undesired behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants