Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed regex for backslash replacement to replace all backslashes #9

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

kaoDev
Copy link
Contributor

@kaoDev kaoDev commented Feb 9, 2018

On windows I just had the error that a path looking like this:

someFolder\%someParam\index

got transformed to this

someFolder/%someParam\index

so only the first backslash got replaced by a normal slash.

The fix is to add a g flag to the replacement regex so that all backslashes match

@coveralls
Copy link

coveralls commented Feb 9, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 77e0ab0 on kaoDev:fix/backslah-replace into ecc3bdd on jesseditson:master.

@jesseditson
Copy link
Owner

Nice catch!

@jesseditson jesseditson merged commit a1c6922 into jesseditson:master Feb 9, 2018
@jesseditson
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants