-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong mastercard pattern #214
Comments
Thanks for reporting this. |
Thank you for this response. I was looking at PR's, and it looks like no one, since 2021, is passing trugh "travis-ci". Do you think that this PR will be merged? |
@jessepollak is in charge of that CI. I can only merge if the CI is passing and it looks dead. So we need @jessepollak to disable the strict PR checks here to allow me to merge and then I can cut a new release. I can cut a new release to NPM without this PR being merged it just feels wrong but you are right what other choice is there. |
@jessepollak could you please help me with this issue? |
i published 2.4.7 in NPM |
Thank you very much for your help! |
The mastercard pattern should be /^(5[1-5]|677189)|^(22[2-9][1-9]|2[3-6]\d{2}|27[0-1]\d|2720)/
A card number starting with 223 is not passing the test, but it should pass.
The text was updated successfully, but these errors were encountered: