Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong mastercard pattern #214

Open
GDMeira opened this issue Aug 2, 2024 · 6 comments · May be fixed by #215 or Stretchy-93/card#2
Open

Wrong mastercard pattern #214

GDMeira opened this issue Aug 2, 2024 · 6 comments · May be fixed by #215 or Stretchy-93/card#2
Assignees
Labels
Milestone

Comments

@GDMeira
Copy link

GDMeira commented Aug 2, 2024

The mastercard pattern should be /^(5[1-5]|677189)|^(22[2-9][1-9]|2[3-6]\d{2}|27[0-1]\d|2720)/
A card number starting with 223 is not passing the test, but it should pass.

@melloware
Copy link
Collaborator

Thanks for reporting this.

@melloware melloware linked a pull request Aug 3, 2024 that will close this issue
@melloware melloware added the bug label Aug 3, 2024
@GDMeira
Copy link
Author

GDMeira commented Aug 5, 2024

Thank you for this response. I was looking at PR's, and it looks like no one, since 2021, is passing trugh "travis-ci". Do you think that this PR will be merged?

@melloware
Copy link
Collaborator

melloware commented Aug 5, 2024

@jessepollak is in charge of that CI. I can only merge if the CI is passing and it looks dead. So we need @jessepollak to disable the strict PR checks here to allow me to merge and then I can cut a new release.

I can cut a new release to NPM without this PR being merged it just feels wrong but you are right what other choice is there.

@GDMeira
Copy link
Author

GDMeira commented Aug 5, 2024

@jessepollak could you please help me with this issue?

@melloware melloware added this to the 2.4.7 milestone Aug 5, 2024
@melloware
Copy link
Collaborator

i published 2.4.7 in NPM

@GDMeira
Copy link
Author

GDMeira commented Aug 5, 2024

Thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants