Rework Debug CodeLens to display on correct documents #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Debug CodeLensProvider incorrectly adds CodeLenses with decorations that may or may not have been updated for the active text editor, and does not handle the case when there is more than one visible text editor. This change shuffles around the Debug CodeLens files, and moves the responsibility for fetching and caching test results into a new `TestResultProvider` class. The relevant methods to parse, join, and sort test results have been extracted from `JestExt`. To improve support for multiple visible text editors, when a test run is complete `updateWithData` will call `triggerUpdateDecorations` for all visible text editors.
|
@orta, the changelog check is working. |
|
Ace 👍 |
orta
reviewed
Dec 19, 2017
|
|
||
| const filePath = document.fileName | ||
| this.testResultProvider.removeCachedResults(filePath) | ||
| } |
There was a problem hiding this comment.
Thanks. Figured I'd practice some test-driven development. I'm happy we both like how it forces you to add seams to write tests. I'm curious if they'll help integrate changes in the long run or just end up "too fragile".
There was a problem hiding this comment.
likely the former, people can trust their changes work as expected
seanpoulter
commented
Dec 20, 2017
src/extension.ts
Outdated
| }) | ||
| }), | ||
|
|
||
| vscode.workspace.onDidCloseTextDocument(extensionInstance.onDidCloseTextDocument) |
There was a problem hiding this comment.
This is throwing an error from onDidCloseTextDocument() because this is null. 😠
|
Alright, things look good to me. I'll clone it and have a test look on some projects before shipping - nice work |
|
looks good - shipped. #116 looks important |
legend1202
pushed a commit
to legend1202/vscode-jest
that referenced
this pull request
Jun 18, 2023
Rework Debug CodeLens to display on correct documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Debug CodeLensProvider incorrectly adds CodeLenses with decorations that may or may not have been updated for the active text editor, and does not handle the case when there is more than one visible text editor.
This change shuffles around the Debug CodeLens files, and moves the responsibility for fetching and caching test results into a new
TestResultProviderclass. The relevant methods to parse, join, and sorttest results have been extracted from
JestExt.To improve support for multiple visible text editors, when a test run is complete
updateWithDatawill calltriggerUpdateDecorationsfor all visible text editors.This fixes #178.
No rush on this one, it's a meaty change. I'd rather we make sure we're invalidating the test result cache is invalidated properly before we ship.