Wrap Error.captureStackTrace in a try
#4035
Merged
+61
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Can you elaborate the code comment a bit, saying that "Guard for some environments (browsers) that do not support this feature."? |
|
Woah, quick! Sure 🙂 |
|
It looks like this, BTW: |
|
Looks good @SimenB! |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Wrap `Error.captureStackTrace` in a try Ref jestjs#4027 * Remove console.log * Add comment * Improve test * Readd assertion * Last assertion tweak
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref #4027
This is a poor-man's version, but it works OK. Not sure we really need to fix it more?
Could put the logic to remove
JestAssertionErroralong with the rest of the stack trace cleanup and avoidError.captureStackTraceall together?/cc @skovhus
Test plan
Tests running in browsers should show assertion errors.