Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Getting rid of verbose and fragile informer construction #69

Closed
munnerz opened this issue Oct 31, 2017 · 0 comments · Fixed by #82
Closed

Getting rid of verbose and fragile informer construction #69

munnerz opened this issue Oct 31, 2017 · 0 comments · Fixed by #82
Assignees
@munnerz

Comments

@munnerz
Copy link
Contributor

munnerz commented Oct 31, 2017

Right now we construct informers through a really horrible and non-type safe SharedInformerFactory, in order to support running in a single namespace (see: https://github.com/jetstack/navigator/blob/master/pkg/controllers/elasticsearch/elasticsearch.go#L311)

We should update this to use a custom generated SharedInformerFactory that supports namespaced resources, and simplify all of this informer handling logic for good.
@munnerz munnerz self-assigned this Oct 31, 2017
@munnerz munnerz mentioned this issue Nov 1, 2017
Merged
jetstack-bot added a commit that referenced this issue Nov 1, 2017
@jetstack-bot
Merge pull request #82 from munnerz/filtered-informers
fb15e9c 
Automatic merge from submit-queue.

Use filtered SharedInformerFactories in controller context

**What this PR does / why we need it**:

Switches to using the new filtered SharedInformerFactories as part of kubernetes/kubernetes#54660

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

fixes #69 

**Special notes for your reviewer**:

Don't merge until #79 has been merged

**Release note**:

```release-note
NONE
```

/assign @wallrj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@munnerz munnerz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use filtered SharedInformerFactories in controller context munnerz/navigator
1 participant
@munnerz