Report errors if no files were found or if source-directories are empty #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishaduck
reviewed
Feb 23, 2025
Comment on lines
+56
to
+58
| const elmFilesToRead = [ | ||
| ...new Set(filesInDirectories.flatMap((directory) => directory.files)) | ||
| ]; |
There was a problem hiding this comment.
Just noticed that is just unique() inlined. Maybe I'll de-inline it someday. Probably not. :)
There was a problem hiding this comment.
Ah right. Yeah I reached out for unique after writing this code. I'll make the change.
There was a problem hiding this comment.
I was rebasing and this made a conflict, so I fixed it in #344.
There was a problem hiding this comment.
Just saw your message. I fixed it in #354, it's on master now 😅
There was a problem hiding this comment.
Already re-(re-?)rebased 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #341, by addressing the root problem.
As @lishaduck pointed out in #341 (comment)
Indeed, when there are no Elm files at all,
elm-reviewhangs. I added a test for it, and we're now exiting with an error should that happen. I also added a specific error (and test) for whensource-directoriesis empty for some reason.I also
uniqued source-directories we're running, because there was some duplicates otherwise, and that was one additionalglobcall.