os.tmpDir() - deprecated #26 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* call [`os.tmpdir()`](https://nodejs.org/api/os.html#os_os_tmpdir) instead of the [deprecated `os.tmpDir()` alias](nodejs/node#6739) * include newer version of cache-swap with [tmpDir -> tmpdir issue fixed](jgable/cache-swap@69fab2b)
|
Thanks for the PR, published as 0.1.0. |
|
And yes, the cache-swap update seems reasonable to include in this PR. Thanks again for taking the time to put the PR up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.tmpdir()instead of the deprecatedos.tmpDir()aliasFull disclosure: Out of an abundance of caution, I just manually hot-dogged in the updated npm shrinkwrap entry for cache-swap because I didn't want to inadvertently break anything else with other dependencies. Not sure if that's frowned upon or not... is the preferred approach to just update all the things and hope nothing breaks?