Skip to content

add method to know if it's a draw by fifty moves or not #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

HarshilPatel007
Copy link
Contributor

@HarshilPatel007 HarshilPatel007 commented Dec 18, 2024

  • added a new method to check whether it's a draw by fifty move rule.
    (This will help UI developers show the exact reason for a draw)
  • added Documentation.

- create a new function to check if it's a draw by fifty moves rule or not.
- this will help UI devs to show exact reason of a draw.
@HarshilPatel007 HarshilPatel007 changed the title add method to know if it's a draw by fifty moves or not. add method to know if it's a draw by fifty moves or not Dec 18, 2024
@jhlywa
Copy link
Owner

jhlywa commented Dec 20, 2024

Thanks for the PR @HarshilPatel007. Could you please split this into two PR's, one for the isFiftyMoveDraw() method and the other for the type annotations? Thanks!

@HarshilPatel007 HarshilPatel007 force-pushed the fiftymove branch 2 times, most recently from a8a5b83 to bfd9bf4 Compare December 23, 2024 08:28
@HarshilPatel007
Copy link
Contributor Author

Hi @jhlywa , sorry for the late reply. It's DONE. Another PR is here : #478

@jhlywa jhlywa merged commit a08df6b into jhlywa:master Dec 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants