Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libjli, not libjvm, on macOS #469

Merged
merged 1 commit into from
Apr 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
'libraries': [
'-L<(javalibdir)',
'-Wl,-rpath,<(javalibdir)',
'-ljvm'
'-ljli'
],
},
],
Expand Down
2 changes: 1 addition & 1 deletion find_java_libdir.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ main () {
target_arch=`uname -m`
if [[ -d ${jre_dir}/${target_arch}/classic ]]; then lib_dir="${jre_dir}"/${target_arch}/classic; else lib_dir="${jre_dir}"/${target_arch}/server; fi
elif [[ "${os}" == "mac" ]]; then
lib_dir="${jre_dir}/server"
lib_dir="${jre_dir}/jli"
else
local arch
if [[ "${target_arch}" =~ (32|386) ]]; then
Expand Down
2 changes: 1 addition & 1 deletion postInstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ require('find-java-home')(function(err, home){

if(home){
dll = glob.sync('**/jvm.dll', {cwd: home})[0];
dylib = glob.sync('**/libjvm.dylib', {cwd: home})[0];
dylib = glob.sync('**/libjli.dylib', {cwd: home})[0];
soFiles = glob.sync('**/libjvm.so', {cwd: home});

if(soFiles.length>0)
Expand Down