Added support for javaType on integer and number properties.

[ctrimble]

This PR adds support for the javaType on integer and number properties.

integer supports the following javaType values:

• int
• java.lang.Integer
• long
• java.lang.Long

number supports the following javaType values:

• float
• java.lang.Float
• double
• java.lang.Double

When javaType is present, the configuration settings are ignored.

[ctrimble]

This relates to #223 and seems to be a regression of #41.

[joelittlejohn]

Ha, so it is. A bit of archeology needed :)

Thanks for submitting this! I'll give it a look over and merge tomorrow.

[ctrimble]

Thanks @joelittlejohn !

[joelittlejohn]

Took a quick look at #41, and no this is not a regression of that change. That change relates to being able to specify primitive types when you use the javaType property inside 'object'.

I'm interested to know what prompted you to make this change. Did you need to change the type of specific properties and not want to change the configuration globally with useLongIntegers/useDoubleNumbers/usePrimitives?

[ctrimble]

@joelittlejohn I needed most of my integer fields to be java.lang.Integer, but a few required java.lang.Long. We were double configuring the maven plugin to do this, but that was a lot of config to get things to work. This seems much more clear.

My current project is polyglot and we are using JSON Schema as a way of keeping our interfaces sane. I am starting to have a lot of schemas in my build, so fine grained control over things like is coming up more frequently.

[ctrimble]

Totally willing to work on this some, if you think the implementation needs to be different.

[joelittlejohn]

Hi Christian. Looks great to me. Lots of tests too so I'm perfectly happy to merge.

To be perfectly honest, I probably would have left this as an unconstrained option and simply used whatever type is found in javaType. E.g. If I want to use BigInteger/BigDecimal I could use that, or maybe my own custom type (as long as I give Jackson a serializer/deserializer for my custom type, it'll work). I'm happy to go with these constraints though as they make sense in most cases. If anyone feels limited by them, we can relax it in a later version.

[ctrimble]

Do you already have a method around that operates like Class.forName(String), but handles primitives like int, long, etc.? If so, I will take a moment and update the PR.

[joelittlejohn]

This class may help:

https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/rules/PrimitiveTypes.java

You could use a check like if (isPrimitive(javaType)) { return primitiveType(javaType); } else { return owner.ref(javaType); } or maybe try { return primitiveType(javaType); } catch (GenerationException e) { return owner.ref(javaType); }. Or something else along those lines :)

[ctrimble]

Cool. Let me take a look at this real quick and add a commit for it. If it looks good, we can squash. If it sucks, we can drop the commit. Would like this to be done right.

[ctrimble]

@joelittlejohn the implementation is generalized. Let me know what you think and I can clean up the history.

[joelittlejohn]

Looks good. Squash away and I'll merge tomorrow. Thanks again for all your contributions!

[ctrimble]

Squashed and ready to merge.