Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios method 'excludeFromBackupKey' is missing from documentation and types #65

Open
JNaftali opened this issue Jun 5, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@JNaftali
Copy link

JNaftali commented Jun 5, 2018

The method still exists (https://github.com/joltup/react-native-fetch-blob/blob/master/ios.js#L41), it's just missing from the wiki documentation (https://github.com/joltup/react-native-fetch-blob/wiki/iOS-API) and the typescript definitions (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native-fetch-blob/index.d.ts).

Since there's already a jsdoc comment I'm assuming adding docs wouldn't be too arduous, but I'm not sure I'm the best person to fix it - I'm running across it being used in some old code but don't quite understand why it would be used.

@Traviskn
Copy link

I don't think there'd be any harm in documenting it, we'd love to get a PR! I also don't know the use case very well, but the comments seem to indicate you can use it to keep iCloud from backing up the file? I imagine you would only need it if you were saving files to a place where iCloud might pick it up, probably a method that is very dependent on the particular use case.

@Traviskn Traviskn added the help wanted Extra attention is needed label Jul 11, 2018
halaei pushed a commit to halaei/rn-fetch-blob that referenced this issue Nov 13, 2021
* removing okhttp3 from dependencies (RN0.66 no longer uses jcenter in general)

Fixes joltup#65

Merge remote-tracking branch 'origin/develop'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants