Parse page properties refactor #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2023 11:45
… byte slice parameter that gets passed in from Properties.UnmarshalJSON
…e into parsePageProperties
jomei
reviewed
Apr 10, 2023
There was a problem hiding this comment.
Hi, @djs-CS! Thanks for the proposal!
Could you please explain the point of these changes? I see that instead of parsing into interface{}, you propose to unmarshal into rawMessage and then unmarshal once again to interface{}. I don't really understand why your approach is better.
|
@jomei - thank you for the consideration and patience! I'm still new to Go and contributing to Open Source generally, so apologies for being unclear with my previous PR. Passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excellent repo! It's been a great reference as I'm learning about building API clients and unmarshaling JSONs in Go. Hope this small change can improve the repo. Any feedback on my proposal would be greatly appreciated.