Stopped click events propagating to map #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #179 |
|
Thanks @alex-Hudson |
mikkokaar
reviewed
Jul 4, 2023
| @@ -208,11 +208,14 @@ export class Internal { | |||
|
|
|||
| //one-time fire | |||
| evt.target.addEventListener( | |||
| 'click', | |||
| 'pointerdown', | |||
There was a problem hiding this comment.
@alex-Hudson & @jonataswalker should this be on click intead of pointerdown?
Had an issue after upgrading to the newest version of ol-contextmenu & ol 7, where contextmenu stopped working on touch devices (didn't register taps but instead closed right away at pointerdown)
Changing this eventlistener back to "click" in a local copy solved it for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
In open layers a simulated click is created on pointerdown event. We dont want this to propagate to the map, so need to stop default when the context menu is clicked