Added updatePosition #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave been fetched from a remote source.
jonataswalker
requested changes
Oct 31, 2016
|
Is there anything more you need me to change now I've backed out the update I did to the built output? |
| @@ -90,6 +90,15 @@ export default class Base extends ol.control.Control { | |||
| } | |||
|
|
|||
| /** | |||
| * Update the menus position. | |||
| */ | |||
| updatePosition(pixel) { | |||
There was a problem hiding this comment.
Add an assertion to ´pixel´ parameter:
utils.assert(Array.isArray(pixel), '@param `pixel` should be an Array.');| @@ -90,6 +90,15 @@ export default class Base extends ol.control.Control { | |||
| } | |||
|
|
|||
| /** | |||
| * Update the menus position. | |||
|
Yes, @Saurbaum there are some inline comments. (I've made them yesterday and forgot to submit) |
Added assertion on the parameter 'pixel'
|
Apologies for that. Still getting to grips with the GitHub interface. |
jonataswalker
approved these changes
Nov 1, 2016
|
Thank you @Saurbaum. Merged. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow you to move the menu once all entries have been fetched from a remote source.