This repository was archived by the owner on Jan 30, 2023. It is now read-only.
Extension for trackEvents() using an MutationObserver. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvanmook
approved these changes
May 20, 2020
|
I also added trackEvents to the react useMatomo function as it can be savely used now (similar to enableLinkTracking). Sry messed up that one merge i have issued via github |
|
@geier1993 Could you allow collaborators on your branch? I would like to make a couple of small changes before merging your PR. |
|
Sry, have no time right now. Added all of you to the collaborators! :) |
|
@geier1993 sorry for the delay! I'm going to publish it asap and let you know when that's done. Thanks for your collaboration! @jonkoops In case you still want to make some changes, let's create another issue for that |
|
@geier1993 I've published v0.1.5 including your changes |
|
Thank you, sorry for having been a little bit unresponsive. Recently I have too much Todo :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now dynamically added elements with custom data attributes are also handled.
#160
I tested it with the example. The correct information is pushed to the
window._paqqueue.Unfortunately it is not possible for me to add a monorepo with npm to our project (we don't have our own npm registry). We need this feature, but we are thinking about just building are own small utils (i.e. just instantiating a global instance and creating global functions... just enough. But the enableLinkTracking with outBoundClickHandler and custome attribute handling is intereting).
If you think you can help me with merging this feature, that would be great!