A number of additional fixes for newer python versions #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This python string tried to load `LooseVersion` from distutils, but that has been removed from python as of 3.12. This version either imports from `distutils` or from `packaging` if that fails. Fix from Christopher Genovese: jorgenschaefer#2051 (comment)
Previous requirements.txt called for setuptools, which will only work before python 3.12.
Fix conditional loading of version on python >= 3.12.
gopar
approved these changes
Apr 4, 2025
|
Thank you for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are actually due to Christopher Genovese in discussion of #2051
The most recent pull request fixes some of the 3.12 incompatibilities but some remain.
This fixes the startup python string in
elpy.eland also some fixes to theblackandjediinterfaces. Finally, it updatesrequirements.txtwith a conditional load ofdistutilsorpackaging.PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
Tests are broken beyond my ability to fix them.