re-export lopdf to prevent having to match the same lopdf version … #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crate consumer's end
monkeydioude
changed the title
|
Should I let the "extern" declarations be, to prevent breaking changes? Became obsolete for this case since Rust 2018 version. |
joepio
approved these changes
Feb 12, 2023
joepio
added a commit
to joepio/pdf-extract
that referenced
this pull request
Feb 12, 2023
joepio
added a commit
to joepio/pdf-extract
that referenced
this pull request
Feb 21, 2023
|
@jrmuizel I was considering making this a separate PR, too but it's already here |
|
Hit this issue while working on langchain-rust. Would be great if lopdf was exported. |
|
I did this in 91b91c5 |
|
Awesome. Would it be possible to release a new crate version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on crate consumer's end + updated examples/extracr.rs