Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepkit-graphql.js.org #8811

Merged
merged 4 commits into from
Feb 8, 2024
Merged

deepkit-graphql.js.org #8811

merged 4 commits into from
Feb 8, 2024

Conversation

marcus-sa
Copy link
Contributor

@indus indus changed the title Update CNAME for deepkit-graphql deepkit-graphql.js.org Feb 6, 2024
@indus indus added user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels Feb 6, 2024
@indus
Copy link
Member

indus commented Feb 6, 2024

I've just changed the subdomain inJS.ORGs zonefile. You may have to configure your host to accept the custom domain. As I got a error page from netlify I wonder why you are not using their default <projectname>.netlify.app as the target.
I'll merge after we have "contact". Please keep this PR open.

@indus indus added the awaiting response This PR is waiting for a response from the requester label Feb 6, 2024
@marcus-sa
Copy link
Contributor Author

marcus-sa commented Feb 6, 2024 •
edited
Loading

I've just changed the subdomain inJS.ORGs zonefile. You may have to configure your host to accept the custom domain. As I got a error page from netlify I wonder why you are not using their default <projectname>.netlify.app as the target. I'll merge after we have "contact". Please keep this PR open.

I'm using https://mintlify.com not https://netlify.app (at least not directly).

I've added deepkit-graphql.js.org as a custom domain.

Screenshot 2024-02-06 at 17 12 34

Hmm, I get a ERR_TOO_MANY_REDIRECTS.

Screenshot_2024-02-06-17-21-37-50_e4424258c8b8649f6e67d283a50a2cbc

@indus
Copy link
Member

indus commented Feb 7, 2024

I don't thing we had a request for a mintlify hosted page before...
From what I can read here: https://mintlify.com/docs/settings/custom-domain/subdomain#configuring-your-dns
it looks like cname.vercel-dns.com is the target. So your request maybe has to look like this (?):
"deepkit-graphql": "cname.vercel-dns.com" // noCF
Can you change your request so I can update JS.ORGs zonefile?

@marcus-sa
Copy link
Contributor Author

I don't thing we had a request for a mintlify hosted page before... From what I can read here: https://mintlify.com/docs/settings/custom-domain/subdomain#configuring-your-dns it looks like cname.vercel-dns.com is the target. So your request maybe has to look like this (?): "deepkit-graphql": "cname.vercel-dns.com" // noCF Can you change your request so I can update JS.ORGs zonefile?

Done 👍🏼

@indus indus removed the awaiting response This PR is waiting for a response from the requester label Feb 8, 2024
@indus
Copy link
Member

indus commented Feb 8, 2024

Welcome back https://deepkit-graphql.js.org

@indus indus merged commit a5545f1 into js-org:master Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcus-sa @indus