sulin.js.org #8821
Closed
sulin.js.org #8821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alltobebetter
commented
Feb 11, 2024
alltobebetter
commented
- There is reasonable content on the page (see: No Content)
- I have read and accepted the Terms and Conditions
MattIPv4
requested changes
Feb 11, 2024
There was a problem hiding this comment.
Hi there!
❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝
| @@ -2977,6 +2977,7 @@ var cnames_active = { | |||
| "suggestcord": "suggestcord.github.io/docs", | |||
| "suggester": "suggester.github.io/Documentation", | |||
| "suka": "sukkaw.github.io", | |||
| "sulin": "https://alltobebetter.github.io/sulinjs/" | |||
There was a problem hiding this comment.
Suggested change
| "sulin": "https://alltobebetter.github.io/sulinjs/" | |
| "sulin": "alltobebetter.github.io/sulinjs", |
As the CI error notes:
- You do not need
https:// - You do not need the trailing
/ - You need a comma at the end of the line
MattIPv4
added
invalid
awaiting CNAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.