Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lt.js.org #8827

Merged
merged 1 commit into from
Feb 13, 2024
Merged

lt.js.org #8827

merged 1 commit into from
Feb 13, 2024

Conversation

lazytong-tech
Copy link
Contributor

See: https://lazytongdev.vercel.app

@MattIPv4
Copy link
Member

I must ask the question, what is the point of this?

Also, Don't worry about the password being leaked because it's stored in the HTML. When lt.js is loaded, it reads and removes the password stored in the HTML, encrypts the password, and stores the encrypted password in multiple variables.. You are aware that you can see the HTML of a page before JavaScript runs? Anything transmitted to the client should be considered public, so a password in client code is not a secure password.

@MattIPv4
Copy link
Member

I should also note you seem to have a history of requesting this/related domains, and them then needing to be removed... https://github.com/js-org/js.org/pulls?q=is%3Apr+lazytong+is%3Aclosed

@lazytong-tech
Copy link
Contributor Author

lazytong-tech commented Feb 13, 2024

Yes. Sorry, I didn't consider this issue when writing. I am currently fixing this issue and will compile it into a static script through node.js instead.

@lazytong-tech
Copy link
Contributor Author

I deleted the domain name before because I didn't have time to continue developing lt.js, but now I am starting to develop this tool again.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://lazytongdev.vercel.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Feb 13, 2024
@indus
Copy link
Member

indus commented Feb 13, 2024

Welcome http://lt.js.org

@indus indus merged commit 5b5a77b into js-org:master Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants