Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop special casing U+0000 in parse fragment #143

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Stop special casing U+0000 in parse fragment #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fead2a9
Stop special casing U+0000 in parse fragment
annevk Apr 27, 2020
851773d
Bump tests to reference the branch
domenic Apr 27, 2020
2659792
Bump to WPT master
domenic Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ This module exports the `URL` and `URLSearchParams` [interface wrappers API](htt

First, install [Node.js](https://nodejs.org/). Then, fetch the dependencies of whatwg-url, by running from this directory:

npm
npm install

To run tests:

Expand Down
2 changes: 1 addition & 1 deletion scripts/get-latest-platform-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ process.on("unhandledRejection", err => {
// 1. Go to https://github.com/w3c/web-platform-tests/tree/master/url
// 2. Press "y" on your keyboard to get a permalink
// 3. Copy the commit hash
const commitHash = "9b7ab1c11b7e0cf9b43ea6dbb282c33e4d193726";
const commitHash = "efec8204e84d434d80407bb7cf8df37d33cabaa1";

const urlPrefix = `https://raw.githubusercontent.com/web-platform-tests/wpt/${commitHash}/url/`;
const targetDir = path.resolve(__dirname, "..", "test", "web-platform-tests");
Expand Down
5 changes: 1 addition & 4 deletions src/url-state-machine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,10 +1154,7 @@ URLStateMachine.prototype["parse query"] = function parseQuery(c, cStr) {
};

URLStateMachine.prototype["parse fragment"] = function parseFragment(c) {
if (isNaN(c)) { // do nothing
} else if (c === 0x0) {
this.parseError = true;
} else {
if (!isNaN(c)) {
// TODO: If c is not a URL code point and not "%", parse error.
if (c === p("%") &&
(!infra.isASCIIHex(this.input[this.pointer + 1]) ||
Expand Down